Fix trainer.test() logging incorrect epoch from checkpoint (#20052)#21714
Open
devraj2307 wants to merge 3 commits into
Open
Fix trainer.test() logging incorrect epoch from checkpoint (#20052)#21714devraj2307 wants to merge 3 commits into
devraj2307 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #20052
Restores the checkpoint epoch and global step when running Trainer.validate(), Trainer.test(), or Trainer.predict() with an explicit ckpt_path.
Previously, these entry points restored the model weights from the requested checkpoint but left the fit-loop progress counters unchanged. As a result, hooks and loggers still
observed the last in-memory training epoch/step instead of the values stored in the selected checkpoint.
This PR:
No breaking changes.
📚 Documentation preview 📚: https://pytorch-lightning--21714.org.readthedocs.build/en/21714/